On 29.10.2012 16:27, Andriy Gapon wrote:
on 29/10/2012 16:18 Alexander Motin said the following:
Author: mav
Date: Mon Oct 29 14:18:54 2012
New Revision: 242314
URL: http://svn.freebsd.org/changeset/base/242314

Log:
   Make GEOM RAID more aggressive in marking volumes as clean on shutdown
   and move that action from shutdown_pre_sync to shutdown_post_sync stage
   to avoid extra flapping.

   ZFS tends to not close devices on shutdown, that doesn't allow GEOM RAID
   to shutdown gracefully.  To handle that, mark volume as clean just when
   shutdown time comes and there are no active writes.

Perhaps something like what zfs_modevent(MOD_UNLOAD) does should also be done in
one of the shutdown hooks?

May be, but I don't know ZFS very good.

Maybe at the start of shutdown_post_sync (so that it is run before the hooks of
lower level drivers like graid)?

graid would be happy if device would be closed at any point of time, either before or after. But before is preferable to avoid some flapping between dirtying and added here cleaning.

--
Alexander Motin
_______________________________________________
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Reply via email to