Author: dumbbell
Date: Tue Dec 18 20:02:53 2012
New Revision: 244405
URL: http://svnweb.freebsd.org/changeset/base/244405

Log:
  psm: Support detection of Synaptics touchpad v7.5 and above
  
  Starting with firmware v7.5, the "Read TouchPad Modes" ($01) and "Read
  Capabilities" ($02) commands changed: previously constant bytes now
  carry variable information.
  
  We now compare those bytes to expected constants only for firmware prior
  to v7.5.
  
  Tested by:    Zeus Panchenko <[email protected]>
  MFC after:    1 week

Modified:
  head/sys/dev/atkbdc/psm.c

Modified: head/sys/dev/atkbdc/psm.c
==============================================================================
--- head/sys/dev/atkbdc/psm.c   Tue Dec 18 18:34:36 2012        (r244404)
+++ head/sys/dev/atkbdc/psm.c   Tue Dec 18 20:02:53 2012        (r244405)
@@ -239,6 +239,10 @@ typedef struct synapticspacket {
 #define SYNAPTICS_QUEUE_CURSOR(x)                                      \
        (x + SYNAPTICS_PACKETQUEUE) % SYNAPTICS_PACKETQUEUE
 
+#define        SYNAPTICS_VERSION_GE(synhw, major, minor)                       
\
+    ((synhw).infoMajor > (major) ||                                    \
+     ((synhw).infoMajor == (major) && (synhw).infoMinor >= (minor)))
+
 typedef struct synapticsaction {
        synapticspacket_t       queue[SYNAPTICS_PACKETQUEUE];
        int                     queue_len;
@@ -867,7 +871,9 @@ doopen(struct psm_softc *sc, int command
        if (sc->hw.model == MOUSE_MODEL_SYNAPTICS) {
                mouse_ext_command(sc->kbdc, 1);
                get_mouse_status(sc->kbdc, stat, 0, 3);
-               if (stat[1] == 0x47 && stat[2] == 0x40) {
+               if ((SYNAPTICS_VERSION_GE(sc->synhw, 7, 5) ||
+                    stat[1] == 0x47) &&
+                   stat[2] == 0x40) {
                        /* Set the mode byte -- request wmode where
                         * available */
                        if (sc->synhw.capExtended)
@@ -4383,7 +4389,7 @@ enable_synaptics(KBDC kbdc, struct psm_s
                return (FALSE);
        if (get_mouse_status(kbdc, status, 0, 3) != 3)
                return (FALSE);
-       if (status[1] != 0x47) {
+       if (!SYNAPTICS_VERSION_GE(synhw, 7, 5) && status[1] != 0x47) {
                printf("  Failed to read extended capability bits\n");
                return (FALSE);
        }
@@ -4439,7 +4445,7 @@ enable_synaptics(KBDC kbdc, struct psm_s
                return (FALSE);
        if (get_mouse_status(kbdc, status, 0, 3) != 3)
                return (FALSE);
-       if (status[1] != 0x47) {
+       if (!SYNAPTICS_VERSION_GE(synhw, 7, 5) && status[1] != 0x47) {
                printf("  Failed to read mode byte\n");
                return (FALSE);
        }
_______________________________________________
[email protected] mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "[email protected]"

Reply via email to