On 2013-02-20 09:32, David Chisnall <[email protected]> wrote:
> On 20 Feb 2013, at 08:25, [email protected] wrote:
> > These should be declared const int *. And the cast shouldn't be
> > needed in C, since void * can be assigned to any other pointer type.
>
> In fact, the entire function body can be replaced with:
>
> return (*(int*)p1 - *(int*)p2);
>
> qsort doesn't require that you return -1, 0, or 1, it requires you return <0,
> 0, or >0.
That's true. Since we are trying to document the interface, I'd prefer
if we don't compress the comparison too much. Would something like this
be ok too?
int
int_compare(const void *p1, const void *p2)
{
const int *left = p1;
const int *right = p2;
return (*left - *right);
}
_______________________________________________
[email protected] mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "[email protected]"
