On 16 July 2013 18:02, John Baldwin <j...@freebsd.org> wrote:
> On Monday, July 15, 2013 11:40:58 am Andrey V. Elsukov wrote:
>> Author: ae
>> Date: Mon Jul 15 15:40:57 2013
>> New Revision: 253367
>> URL: http://svnweb.freebsd.org/changeset/base/253367
>>
>> Log:
>> Include sys/systm.h after sys/param.h.
>>
>> Suggested by: pluknet
>
> Does this fix something?
>
> The normal style rule IIUC is to put <sys/types.h> or <sys/param.h> first,
> and then to sort alphabetically.
In addition to the style bug mentioned by Bruce, this also fixes build error
on i386. See r252434, r253351 for details.
In file included from /src/sys/i386/i386/uio_machdep.c:48:
/src/sys/sys/systm.h:190:6: error: conflicting types for 'critical_exit'
void critical_exit(void);
^
./machine/counter.h:172:3: note: previous implicit declaration is here
critical_exit();
^
JFYI.
--
wbr,
pluknet
_______________________________________________
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
