On 7/27/13 12:47 AM, Bruce Evans wrote: > On Fri, 26 Jul 2013, Juli Mallett wrote: > >> On Fri, Jul 26, 2013 at 2:26 PM, Andrey Zonov <z...@freebsd.org> wrote: >> >>> On 7/26/13 8:09 AM, Jilles Tjoelker wrote: >>>> As noted in mail from Bruce Evans, please preserve the ABI of >>>> VM_SWAPPING_ENABLED here. >>> >>> I don't think it's a big problem. Internally we don't use it. Good >>> code uses sysctlbyname() instead of sysctl(). It doesn't seem to me >>> this is very popular sysctl. It's also CURRENT without MFC. >> >> That doesn't seem like a great argument. >> >> Why should we break the ABI for bad code that used that sysctl and all >> following? It seems pretty trivial to preserve, and no-cost. Also, the >> fact that it's in current misses the point completely: it breaks ABI with >> older binaries, namely older binaries running on -CURRENT. And not just >> for that field. > > Especially since the main reason numbered sysctls exist is to support old > binaries (and sources) that use them. >
Does it look OK?
diff --git a/sys/vm/vm_param.h b/sys/vm/vm_param.h
index 44306be..0323473 100644
--- a/sys/vm/vm_param.h
+++ b/sys/vm/vm_param.h
@@ -82,8 +82,9 @@
#define VM_V_CACHE_MIN 7 /* cnt.v_cache_min */
#define VM_V_CACHE_MAX 8 /* cnt.v_cache_max */
#define VM_V_PAGEOUT_FREE_MIN 9 /* cnt.v_pageout_free_min */
-#define VM_SWAPPING_ENABLED 10 /* swapping enabled */
-#define VM_MAXID 11 /* number of valid vm ids */
+/*#define VM_PAGEOUT_ALGORITHM 10 pageout algorithm */
+#define VM_SWAPPING_ENABLED 11 /* swapping enabled */
+#define VM_MAXID 12 /* number of valid vm ids */
#define CTL_VM_NAMES { \
{ 0, 0 }, \
@@ -96,6 +97,7 @@
{ "v_cache_min", CTLTYPE_UINT }, \
{ "v_cache_max", CTLTYPE_UINT }, \
{ "v_pageout_free_min", CTLTYPE_UINT}, \
+ { "obsolete_pageout_algorithm", CTLTYPE_INT}, \
{ "swap_enabled", CTLTYPE_INT},\
}
--
Andrey Zonov
signature.asc
Description: OpenPGP digital signature
