On 1 Dec 2013, at 07:59, Konstantin Belousov <[email protected]> wrote:

> Revert the drm2/i915 changes from this and following commits now.
> You did not contacted obvious maintainer of the file.
> 
> The changes are pointless and make the import of upstream changes
> harder; for i915_reg.h, much harder.
> 
> Not to mention that the whole churn is not needed if the
> -fno-strict-overflow flag is used.

If supporting code that is obviously wrong (as in this case, as the compiler 
will happily tell you if you don't explicitly silence warnings) is the 
justification for wanting -fno-strict-overflow, then this is a very flimsy 
justification.

David

_______________________________________________
[email protected] mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "[email protected]"

Reply via email to