Author: hselasky
Date: Sun Apr 27 15:41:44 2014
New Revision: 265015
URL: http://svnweb.freebsd.org/changeset/base/265015
Log:
Setting the IMOD value below 0x3F8 can cause IRQ lockups in the Intel
LynxPoint USB 3.0 controllers found in MacBookPro 2013's.
MFC after: 2 days
Tested by: Huang Wen Hui <huang...@gmail.com>
Modified:
head/sys/dev/usb/controller/xhci.c
head/sys/dev/usb/controller/xhci.h
head/sys/dev/usb/controller/xhci_pci.c
head/sys/dev/usb/controller/xhcireg.h
Modified: head/sys/dev/usb/controller/xhci.c
==============================================================================
--- head/sys/dev/usb/controller/xhci.c Sun Apr 27 15:14:59 2014
(r265014)
+++ head/sys/dev/usb/controller/xhci.c Sun Apr 27 15:41:44 2014
(r265015)
@@ -495,8 +495,12 @@ xhci_start_controller(struct xhci_softc
XWRITE4(sc, runt, XHCI_ERSTSZ(0), XHCI_ERSTS_SET(temp));
+ /* Check if we should use the default IMOD value */
+ if (sc->sc_imod_default == 0)
+ sc->sc_imod_default = XHCI_IMOD_DEFAULT;
+
/* Setup interrupt rate */
- XWRITE4(sc, runt, XHCI_IMOD(0), XHCI_IMOD_DEFAULT);
+ XWRITE4(sc, runt, XHCI_IMOD(0), sc->sc_imod_default);
usbd_get_page(&sc->sc_hw.root_pc, 0, &buf_res);
Modified: head/sys/dev/usb/controller/xhci.h
==============================================================================
--- head/sys/dev/usb/controller/xhci.h Sun Apr 27 15:14:59 2014
(r265014)
+++ head/sys/dev/usb/controller/xhci.h Sun Apr 27 15:41:44 2014
(r265015)
@@ -481,6 +481,7 @@ struct xhci_softc {
uint16_t sc_erst_max;
uint16_t sc_event_idx;
uint16_t sc_command_idx;
+ uint16_t sc_imod_default;
uint8_t sc_event_ccs;
uint8_t sc_command_ccs;
Modified: head/sys/dev/usb/controller/xhci_pci.c
==============================================================================
--- head/sys/dev/usb/controller/xhci_pci.c Sun Apr 27 15:14:59 2014
(r265014)
+++ head/sys/dev/usb/controller/xhci_pci.c Sun Apr 27 15:41:44 2014
(r265015)
@@ -242,6 +242,7 @@ xhci_pci_attach(device_t self)
case 0x1e318086: /* Panther Point */
case 0x8c318086: /* Lynx Point */
sc->sc_port_route = &xhci_pci_port_route;
+ sc->sc_imod_default = XHCI_IMOD_DEFAULT_LP;
break;
default:
break;
Modified: head/sys/dev/usb/controller/xhcireg.h
==============================================================================
--- head/sys/dev/usb/controller/xhcireg.h Sun Apr 27 15:14:59 2014
(r265014)
+++ head/sys/dev/usb/controller/xhcireg.h Sun Apr 27 15:41:44 2014
(r265015)
@@ -166,7 +166,8 @@
#define XHCI_IMOD_IVAL_SET(x) (((x) & 0xFFFF) << 0) /* 250ns unit */
#define XHCI_IMOD_ICNT_GET(x) (((x) >> 16) & 0xFFFF) /* 250ns unit */
#define XHCI_IMOD_ICNT_SET(x) (((x) & 0xFFFF) << 16) /* 250ns unit */
-#define XHCI_IMOD_DEFAULT 0x000001F4U /* 8000 IRQ/second */
+#define XHCI_IMOD_DEFAULT 0x000001F4U /* 8000 IRQs/second */
+#define XHCI_IMOD_DEFAULT_LP 0x000003F8U /* 4000 IRQs/second -
LynxPoint */
#define XHCI_ERSTSZ(n) (0x0028 + (0x20 * (n))) /* XHCI event
ring segment table size */
#define XHCI_ERSTS_GET(x) ((x) & 0xFFFF)
#define XHCI_ERSTS_SET(x) ((x) & 0xFFFF)
_______________________________________________
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
