On Aug 4, 2014, at 10:24 AM, Garrett Cooper <[email protected]> wrote:

> Hi Bruce!
> 
> On Aug 4, 2014, at 2:23 AM, Bruce Evans <[email protected]> wrote:
> 
>> On Mon, 4 Aug 2014, Garrett Cooper wrote:
> 
> ...
> 
>> I hope this fixes the error found by "make checkdpadd".  -L is too hard
>> for the current "make checkdpadd" to handle.  Old aout versions worked
>> better using linker support.  They also found the correct dependencies
>> (on shared libraries for shared linkage, not the pseudo-dependenci on
>> the hard-coded static librar for shared linkage).
> 
> Thank you for the reminder about that make target :).

And this still fails make checkdpadd :(...

>> "make checkdpadd" currently finds broken 143 makefiles with inconsistent
>> DPADD.  62 of them are for clang.  Most of these misuse DPADD for
>> headers.  The next largest source of errors is libtermcapw.  LIBTERMCAPW
>> is missing in bsd.libnames.mk.  This breaks about 29 makefiles where
>> LIBTERMCAP was blindly replaced by LIBTERMCAPW.  bsd.libnames.mk and
>> DPADD were unnecessary with the old aout versions.
> 
> I’ll file bugs for any issues I find and work with maintainers to fix the 
> issues. I’m not sure if you’re on Phabricator, but I’d be happy to add you to 
> the reviews if you would like.

I filed bugs for the bulk majority of the issues I found with make checkdpadd.

Thanks!
-Garrett

Attachment: signature.asc
Description: Message signed with OpenPGP using GPGMail

Reply via email to