On Jul 5, 2015, at 13:49, Garrett Cooper <[email protected]> wrote:
> On Jul 5, 2015, at 13:05, Ian Lepore <[email protected]> wrote: > >> On Sun, 2015-07-05 at 12:49 -0700, John-Mark Gurney wrote: >>> Ian Lepore wrote this message on Sun, Jul 05, 2015 at 14:15 +0000: >>>> Author: ian >>>> Date: Sun Jul 5 14:15:58 2015 >>>> New Revision: 285160 >>>> URL: https://svnweb.freebsd.org/changeset/base/285160 >>>> >>>> Log: >>>> Ensure all the required files get built when you include the IPSEC option. >>> >>> Umm.. This looks more like that IPSEC should require that the crypto >>> device be specified instead of fixing it this way... >> >> I considered that, but rejected it given the presence of crypto | ipsec >> on some of the files already, but not a sufficiency of them to actually >> build sucessfully. Heavily my thinking that was a personal belief that >> if you say "option foo" it should just work without you needing to know >> other (likely not well documented) prerequisite options also need to be >> set. > > Or… just create a manpage that says “options IPSEC” requires “device crypto”? Oh wait — there already is one and it states exactly that... https://www.freebsd.org/cgi/man.cgi?query=ipsec&apropos=0&sektion=0&manpath=FreeBSD+10.1-RELEASE&arch=default&format=html . Maybe just add some comments in the KERNCONFs to note that “options IPSEC” requires “device crypto”?
signature.asc
Description: Message signed with OpenPGP using GPGMail
