On 26.08.2015 23:53, Konstantin Belousov wrote:
> On Wed, Aug 26, 2015 at 09:35:16PM +0000, Baptiste Daroussin wrote:
>> -static bool
>> +static inline bool
>> i915_gem_object_is_inactive(struct drm_i915_gem_object *obj)
>> {
>> -
>> - return !obj->active;
>> + return obj->gtt_space && !obj->active;
>
> Why is this correct ?
obj->gtt_space is NULL when the object is not mapped in the global GTT.
This check was added in 6c085a728cf000ac1865d66f8c9b52935558b328
("drm/i915: Track unbound pages"), first released in Linux 3.7.
But now that I think of it again, it may not be correct with the current
driver (and only correct in the context of a 3.8-era driver).
Baptiste, could you please revert that part?
--
Jean-Sébastien Pédron
signature.asc
Description: OpenPGP digital signature
