On 09/12/15 at 07:23P, Eric Joyner wrote: > For the errata, the (lack of) details are in the specification updates for > HW like I210, I211, 82575 etc. It would be in the ones updated in August > 2015.
Yes, I (we) know erratas are there in the h/w specs. Point is, which exact errata problem are you fixing here so I can go look up the spec for more detail. Errata number/name and exact spec should also be quoted for less ambiguity. (Think about someone having to debug this code 5 years down the road.) Cheers, Hiren > > On Fri, Sep 4, 2015 at 9:18 AM hiren panchasara <hi...@strugglingcoder.info> > wrote: > > > + erj > > > > On 09/04/15 at 04:07P, Sean Bruno wrote: > > > Author: sbruno > > > Date: Fri Sep 4 16:07:27 2015 > > > New Revision: 287465 > > > URL: https://svnweb.freebsd.org/changeset/base/287465 > > > > > > Log: > > > igb(4): Update and fix HW errata > > > - HW errata workaround for IPv6 offload w/ extension headers > > It would be useful to know what is the actual problem here. > > > > > - Edited start of if_igb.c (Device IDs / #includes) to match ixgbe/ixl > > I'd also prefer if such changes come via separate commits. :-) > > > > > > > > Differential Revision: https://reviews.freebsd.org/D3165 > > > Submitted by: erj > > > MFC after: 1 month > > > Sponsored by: Intel Corporation > > > > > > Modified: > > > head/sys/dev/e1000/if_igb.c > > > head/sys/dev/e1000/if_igb.h > > > > [skip] > > > > Cheers, > > Hiren > >
pgpWj5Hs1hpnr.pgp
Description: PGP signature