On 09/15/15 23:30, Allan Jude wrote:
On 2015-09-16 02:12, Nathan Whitehorn wrote:
Can we please fix this elsewhere? Like in gpart? As it is, this
mechanism is super-fragile: it applies only for one of the two ways of
configuring ZFS systems, and that only when running an interactive
install. It's somewhat alleviated by the fact that the other cases can
set up UEFI boot, but still... Putting it here also causes various spam
messages when running on non-x86 systems.
At the very least, it should be in zfsboot, not the auto script. That
will clean this up and make the fix apply to scripted installations as
well.
-Nathan
It is setup in scripts/auto specifically because it DOES apply to both
modes (zfsboot and partedit). It applies to UFS in partedit as well.
I missed that, sorry (could you add me to reviews on partitioning in the
future?). There's still the issue that it doesn't apply to scripted
installs. The mechanism used in gpart_ops.c also causes silent changes
to disks that are already partitioned, which it should not do, since it
sets these properties at the wrong time (completion of installation,
rather than creation of the partition map).
The various spam messages on non-x86 are from the missing kenv? I should
be able to fix that.
Yes. Could you please fix the following?
1. Set the scheme properties in partedit when the scheme is created (in
gpart_create(), potentially through a callback into partedit_x86.c).
2. Come up with an autodetection scheme that does not rely on putting
things in scripts/auto. Doing it there breaks scripted installs on these
systems as well as interactive disk setup through sade(8). All
scripts/auto is supposed to do is run the other tools in sequence and
give the user some menus.
3. Only run these tests on x86 systems. They are unnecessary/harmful on
other platforms and the kenvs you are checking don't exist there anyway.
-Nathan
On 09/15/15 20:32, Allan Jude wrote:
Author: allanjude
Date: Wed Sep 16 03:32:27 2015
New Revision: 287843
URL: https://svnweb.freebsd.org/changeset/base/287843
Log:
Add a number of models to the bsdinstall GPT hack blacklist
PR: 194359
Approved by: bapt (mentor)
MFC after: 2 weeks
Sponsored by: ScaleEngine Inc.
Differential Revision: https://reviews.freebsd.org/D3525
Modified:
head/usr.sbin/bsdinstall/scripts/auto
Modified: head/usr.sbin/bsdinstall/scripts/auto
==============================================================================
--- head/usr.sbin/bsdinstall/scripts/auto Wed Sep 16 03:03:19
2015 (r287842)
+++ head/usr.sbin/bsdinstall/scripts/auto Wed Sep 16 03:32:27
2015 (r287843)
@@ -201,6 +201,19 @@ if f_interactive; then
;;
esac
;;
+ "Hewlett-Packard")
+ case "$sys_model" in
+ "HP ProBook 4330s")
+ dialog_workaround "$msg_gpt_active_fix"
+ retval=$?
+ f_dprintf "gpt_active_fix_prompt=[%s]" "$retval"
+ if [ $retval -eq $DIALOG_OK ]; then
+ export ZFSBOOT_PARTITION_SCHEME="GPT + Active"
+ export WORKAROUND_GPTACTIVE=1
+ fi
+ ;;
+ esac
+ ;;
esac
#
# Motherboard Models
@@ -208,7 +221,20 @@ if f_interactive; then
case "$sys_mb_maker" in
"Intel Corporation")
case "$sys_mb_product" in
- "DP965LT")
+ "DP965LT"|"D510MO")
+ dialog_workaround "$msg_gpt_active_fix"
+ retval=$?
+ f_dprintf "gpt_active_fix_prompt=[%s]" "$retval"
+ if [ $retval -eq $DIALOG_OK ]; then
+ export ZFSBOOT_PARTITION_SCHEME="GPT + Active"
+ export WORKAROUND_GPTACTIVE=1
+ fi
+ ;;
+ esac
+ ;;
+ "Acer")
+ case "$sys_mb_product" in
+ "Veriton M6630G")
dialog_workaround "$msg_gpt_active_fix"
retval=$?
f_dprintf "gpt_active_fix_prompt=[%s]" "$retval"
_______________________________________________
[email protected] mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "[email protected]"
