On 9/26/2015 7:19 AM, Warner Losh wrote: > > > On Fri, Sep 25, 2015 at 11:11 PM, NGie Cooper <[email protected] > <mailto:[email protected]>> wrote: > > On Fri, Sep 25, 2015 at 4:13 PM, Bryan Drewery <[email protected] > <mailto:[email protected]>> wrote: > > On 9/25/2015 4:12 PM, NGie Cooper wrote: > >> On Fri, Sep 25, 2015 at 4:03 PM, Bryan Drewery <[email protected] > <mailto:[email protected]>> wrote: > >>> Author: bdrewery > >>> Date: Fri Sep 25 23:03:32 2015 > >>> New Revision: 288241 > >>> URL: https://svnweb.freebsd.org/changeset/base/288241 > >>> > >>> Log: > >>> Remove 'set -e' that are no longer needed as it is already default. > >>> > >>> When bmake was initially imported at r241298 shell commands were no > longer > >>> ran with 'set -e' as they were before. This was fixed in r254980 > so they > >>> again always use 'set -e'. > >> > >> The bsd.subdir.mk <http://bsd.subdir.mk> portion of the change looks > like it would cause > >> issues depending on what's being called (fmake or an earlier version > >> of sys.mk <http://sys.mk> might be used at install time). > >> > > > > We only support bmake in head. And the 'set -e' were only added for > > bmake compatibility before it was fixed to work like fmake did. > > Sorry. Fuzzy memory on the latter item. Yeah, I requested it a > couple years ago. > > We might only support bmake in head, but there's nothing preventing > someone from doing a source upgrade from one of the older 10 releases > to 11+. Thinking about this a bit more, this is an extreme edge case > that doesn't really matter, because people doing source upgrades > across major releases really should be doing them from the latest > minor release for the major release > > > I wouldn't state it so glibly. It is not as extreme as you might think. > For a > long time compiling -current from a host that was one or two major > releases old has worked. Currently we advertise that we can upgrade > from the stable/9 branch point or newer to tip of head (based on values > in Makefile.inc1). > > I don't believe that Bryan's change set changes that in any significant way, > but given the large amount of churn he and I (and others) have generated in > /usr/share/mk, testing from a 9.x machine would be prudent. I didn't remove > some minor bits of code, and also made sys.mk <http://sys.mk> compatible > with the FreeBSD 9 > fmake because of issues like this. >
Note that fmake compatibility was explicitly removed around the META_MODE import time. fmake doesn't work at all currently. -- Regards, Bryan Drewery
signature.asc
Description: OpenPGP digital signature
