On 10/15/2015 6:26 PM, Ian Lepore wrote: > On Thu, 2015-10-15 at 17:36 -0700, Bryan Drewery wrote: >> On 10/15/2015 5:32 PM, Ian Lepore wrote: >>> On Thu, 2015-10-15 at 16:51 -0700, Bryan Drewery wrote: >>>> On 10/15/2015 4:37 PM, Bryan Drewery wrote: >>>>> On 10/15/2015 3:55 PM, Bryan Drewery wrote: >>>>>> Author: bdrewery >>>>>> Date: Thu Oct 15 22:55:08 2015 >>>>>> New Revision: 289393 >>>>>> URL: https://svnweb.freebsd.org/changeset/base/289393 >>>>>> >>>>>> Log: >>>>>> Add more SUBDIR_PARALLEL. >>>>>> >>>>>> MFC after: 3 weeks >>>>>> Sponsored by: EMC / Isilon Storage Division >>>>> >>>>> I forgot to test installworld with -j. It appears there is an >>>>> issue >>>>> there. I will look into it later tonight. >>>>> >>>> >>>> OK it is fine. The issue was missing directories in >>>> etc/mtree/BSD.usr.dist. Resolved. >>>> >>>> I should mention too that soon I expect these SUBDIR_PARALLEL to >>>> come >>>> out and be replaced with NO_SUBDIR_PARALLEL where needed. >>>> >>> >>> That seems to imply that the default is going to flip to always >>> building parallel unless it's supressed by specific makefiles. >>> >> >> Yes. It will be safe to do so if building in the src tree, but not >> when >> building outside of the src tree. > > I'm not sure what you mean by that. It's going to break anybody who > uses the freebsd machinery to build code other than /usr/src and has > embraced the SUBDIR_PARALLEL thing, is that what you mean? >
Sorry, I realized after sending that it may have been unclear. Yes it would not be safe to force this feature on some build that is not actually /usr/src, but is just some program that is using /usr/share/mk. So this on-by-default feature would only apply to src builds. We have the power to ensure features are limited to in-tree /usr/src builds. -- Regards, Bryan Drewery
signature.asc
Description: OpenPGP digital signature
