-----Original Message-----
From: Jason Harmening <[email protected]>
Date: 2016-05-19, Thursday at 21:05
To: Ravi Pokala <[email protected]>, "Jason A. Harmening" <[email protected]>, 
<[email protected]>, <[email protected]>, 
<[email protected]>
Subject: Re: svn commit: r300258 - head/sys/dev/iicbus

>On 05/19/16 20:50, Ravi Pokala wrote:
>> -----Original Message-----
>> From: <[email protected]> on behalf of "Jason A. Harmening" 
>> <[email protected]>
>> Date: 2016-05-19, Thursday at 20:03
>> To: <[email protected]>, <[email protected]>, 
>> <[email protected]>
>> Subject: svn commit: r300258 - head/sys/dev/iicbus
>> 
>> Hi Jason,
>> 
>> If I’m reading that right, it’s not preventing any allocations, but it is 
>> preventing a leak. Is that correct?
>> 
>> Thanks,
>> 
>> Ravi (rpokala@)
>
>Hi Ravi,
>
>There shouldn't be a leak in here, but checking the result prevents
>falling through the rest of the function, including the unnecessary
>malloc of usrbufs right after this.

How did I miss that earlier? Time for new glasses! :-P

>It also makes the error handling clearer.

Yeah.

>Thanks,
>Jason

Thank *you*,

Ravi (rpokala@)



_______________________________________________
[email protected] mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "[email protected]"

Reply via email to