On Tue, Jul 19, 2016 at 01:43:16PM +0200, Randall Stewart wrote: > Gleb > > Ok > > I have now updated > > https://reviews.freebsd.org/D7135 > > You can take this or not… I really don’t care either way… (you are welcome to > own the kern_timeout.c code I hate it) :-) > > Basically when you went off and re-factored kern_timeout.c I had worked in > parallel on fixing > the bugs you were seeing.. There were three distinct problems that I fixed… > but then > you had refactored the stop() routine.. and I thought ok.. thats fine. I had > actually thought about > doing something similar to what you did and was too chicken to poke that much > at it.. it has > always had a nasty habit of biting back when you make a lot of changes :-D > > I know my version has worked for quite some time in my testing so I brought > it back. > Complete with its 3 return codes (I only recently switched to your version > and thus > started having difficulties with leaks and crashes)…. > > You are welcome not to use this.. I know it works (it ran > on a number of machines at NF last night.. and we will of course continue > testing > it as we finish our dev testing for the upcoming OCA software release).. For > now > this is what will be going out into the OCA’s at least :-) >
I'm honestly done with this topic, and at the point now where I'm considering backing out all changes to callout(9) and related changes to the state they were at in stable/10. This changes the KBI, and if it needs to be done, it needs to happen now. We cannot wait for RC1 phase for this, and the amount of churn to get things into a working state with the current implementation far outweighs the benefit of the dangers. Glen
signature.asc
Description: PGP signature
