On 08/01/16 00:28, Xin Li wrote:
On 7/31/16 14:36, Pedro F. Giffuni wrote:
Author: pfg
Date: Sun Jul 31 21:36:40 2016
New Revision: 303600
URL: https://svnweb.freebsd.org/changeset/base/303600
Log:
indent(1): replace function call to bzero with memset.
Reference:
https://github.com/pstef/freebsd_indent/commit/7422f42f80099c69d34833d7106035dc09230235
Differential Revision: https://reviews.freebsd.org/D6966 (Partial)
Submitted by: Piotr Stefaniak
Modified:
head/usr.bin/indent/io.c
Modified: head/usr.bin/indent/io.c
==============================================================================
--- head/usr.bin/indent/io.c Sun Jul 31 21:29:10 2016 (r303599)
+++ head/usr.bin/indent/io.c Sun Jul 31 21:36:40 2016 (r303600)
@@ -629,7 +629,7 @@ parsefont(struct fstate *f, const char *
const char *s = s0;
int sizedelta = 0;
- bzero(f, sizeof *f);
+ memset(f, 0, sizeof(struct fstate));
^^^^^^^^^^^^^^^^^^^^^ This is much more error-prone
than sizeof(*f) IMHO.
Cheers,
Does this look better?
Cheers,
Pedro.
Index: usr.bin/indent/io.c
===================================================================
--- usr.bin/indent/io.c (revision 303615)
+++ usr.bin/indent/io.c (working copy)
@@ -629,7 +629,7 @@
const char *s = s0;
int sizedelta = 0;
- memset(f, 0, sizeof(struct fstate));
+ memset(f, '\0', sizeof(*f));
while (*s) {
if (isdigit(*s))
f->size = f->size * 10 + *s - '0';
_______________________________________________
[email protected] mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "[email protected]"
