Is there to be an MFC for the below? > Author: jhibbits > Date: Sat Aug 6 15:10:14 2016 > New Revision: 303797 > URL: > https://svnweb.freebsd.org/changeset/base/303797 > > > Log: > Check the first byte of the array for NUL, instead of the array as a NULL > pointer > > The partition_name field is an array, so can never be NULL itself. Check > only > the first byte instead. > > This was found when test building with clang, but I'm not sure how it passes > gcc's warnings either. > > Modified: > head/contrib/binutils/bfd/ppcboot.c > > Modified: head/contrib/binutils/bfd/ppcboot.c > ============================================================================== > --- head/contrib/binutils/bfd/ppcboot.c Sat Aug 6 15:06:19 2016 > (r303796) > +++ head/contrib/binutils/bfd/ppcboot.c Sat Aug 6 15:10:14 2016 > (r303797) > @@ -419,7 +419,7 @@ ppcboot_bfd_print_private_bfd_data (abfd > if (tdata->header.os_id) > fprintf (f, "OS_ID = 0x%.2x\n", tdata->header.os_id); > > - if (tdata->header.partition_name) > + if (tdata->header.partition_name[0]) > fprintf (f, _("Partition name = \"%s\"\n"), > tdata->header.partition_name); > > for (i = 0; i < 4; i++)
=== Mark Millard markmi at dsl-only.net _______________________________________________ [email protected] mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "[email protected]"
