On 17 Nov 2016, at 01:31, Ngie Cooper <[email protected]> wrote: > > On Wed, Nov 16, 2016 at 2:14 PM, Mark Johnston <[email protected]> wrote: > ... >> This appears to install hv_kvp_daemon and hv_vss_daemon to / instead of >> /usr/sbin, and breaks the -DNO_ROOT build. I think a Makefile.inc is >> needed in usr.sbin/hyperv/tools in order to preserve BINDIR from >> usr.sbin/Makefile.inc. I fixed the problem in my tree with the diff >> below, but am not sure if this is the right way to do it. For some >> reason, doing this resulted in unused var warnings compiling >> hv_vss_daemon.c. > > The -Wunused warnings you're seeing are because you're now it's > setting WARNS by .include'ing usr.bin/Makefile.inc ; it used to be set > (I verified that), but then got unset between a few weeks ago and now > on the directory: > > $ make -V.CURDIR -VWARNS > /usr/src/usr.sbin/hyperv/tools > > $ > > Cheers, > -Ngie > > PS -Wno-uninitialized is only set for gcc...? Really...???
Yes, because base gcc has produced many false positives with its -Wuninitialized warnings. In fact, I would suggest that is globally turned off for any gcc version before 4.7. -Dimitry
signature.asc
Description: Message signed with OpenPGP using GPGMail
