Re: svn commit: r313962 - in head: etc/mtree sys/boot/geli sys/geom/eli tests/sys/geom tests/sys/geom/eli tests/sys/geom/eli/pbkdf2

[Ngie Cooper (yaneurabeya)]

> On Feb 19, 2017, at 13:07, Allan Jude <allanj...@freebsd.org> wrote:

…

> Sorry, I didn't think it actually built these tests unless testvect.h
> did not exist.
> 
> These tests were written by jmg@, years ago, but by me.
> 
> What do you think the best course of action is? Just disconnect this test?

        To be safe, I’d probably just disconnect the dependency since the 
generated file (I assume) works by itself, e.g.

$ svn diff tests/sys/geom/eli/pbkdf2/Makefile
Index: tests/sys/geom/eli/pbkdf2/Makefile
===================================================================
--- tests/sys/geom/eli/pbkdf2/Makefile  (revision 313971)
+++ tests/sys/geom/eli/pbkdf2/Makefile  (working copy)
@@ -22,7 +22,7 @@

 LIBADD.pbkdf2= crypto

-testvect.h:    gentestvect.py
+testvect.h:
        python gentestvect.py > $@

 .include <bsd.test.mk>

        We can work on removing the python dependency in the interim.
Thanks,
-Ngie

signature.asc
Description: Message signed with OpenPGP using GPGMail