On 2/23/2017 12:13 PM, Benjamin Kaduk wrote:
On Thu, Feb 23, 2017 at 9:30 AM, Pedro F. Giffuni <p...@freebsd.org <mailto:p...@freebsd.org>> wrote:Author: pfg Date: Thu Feb 23 15:30:21 2017 New Revision: 314142 URL: https://svnweb.freebsd.org/changeset/base/314142 <https://svnweb.freebsd.org/changeset/base/314142> Log: dev/ce: double assignment. The code is not operational right now so just comment away an obviously useless assignment. Fix some typos while here. Found with: coccinelle (da.cocci) Modified: head/sys/dev/ce/ceddk.c Modified: head/sys/dev/ce/ceddk.c ==============================================================================--- head/sys/dev/ce/ceddk.c Thu Feb 23 15:10:46 2017 (r314141) +++ head/sys/dev/ce/ceddk.c Thu Feb 23 15:30:21 2017 (r314142)@@ -632,8 +632,8 @@ void ce_stop_chan (ce_chan_t *c) "UserRequest (%s:%d)\n", __FUNCTION__, __LINE__)); return; } - req->Command = TAU32_Configure_Commit | - TAU32_Tx_Stop | TAU32_Rx_Stop; +// req->Command = TAU32_Configure_Commit | +// TAU32_Tx_Stop | TAU32_Rx_Stop; Should probably stick to C-style comments, though.
They are valid C99 comments but I understand what you mean, OTOH, the code block appears to be so broken, that it doesn't matter. Pedro.
-Ben
_______________________________________________ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
