On Apr 21, 2017, at 18:06, Dag-Erling Smørgrav <[email protected]> wrote: > > Author: des > Date: Sat Apr 22 01:06:23 2017 > New Revision: 317277 > URL: https://svnweb.freebsd.org/changeset/base/317277 > > Log: > Fix counter increment in Salsa and ChaCha. > > In my eagerness to eliminate a branch which is taken once per 2^38 > bytes of keystream, I forgot that the state words are in host order. > Thus, the counter increment code worked fine on little-endian > machines, but not on big-endian ones. Switch to a simpler (branchful) > solution.
I’m surprised there’s no mention of who reviewed your change, especially when you’re changing crypto code. _______________________________________________ [email protected] mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "[email protected]"
