> On Jun 1, 2017, at 10:16, Alexey Dokuchaev <da...@freebsd.org> wrote: > > On Thu, Jun 01, 2017 at 09:58:38AM -0700, Simon J. Gerraty wrote: >> One option would be to store a sha256 hash of the result. >> If the image generated by the test hashes to the correct value - you >> pass. > > That should be preferred. Storing binary blobs in VCS is bad practice. > >> Of course if the test fails, you are completely in the dark as to >> how/why. > > Not really: you checkout previous version (which produces correct hash) > and store generated image for later inspection and diffing. > >> Is storing img-1x1-512-mbr.vmdk.gz any more palatable? > > This is barely acceptable, but only if image was zerofied/sparsed prior > to compression. Also, the image should be of the minimal (sufficient) > working size.
I vote for not checking in the SHAs. If something fails (as someone
else mentioned on the lists), it’s really hard to debug why it failed.
I think marcel@’s proposal for hexdump -C text dumps are the best way
to handle this.
Thanks,
-Ngie
signature.asc
Description: Message signed with OpenPGP using GPGMail
