On 2017-11-03 17:22, Alexander Leidinger wrote:
Quoting Vladimir Kondratyev <w...@freebsd.org> (from Wed, 1 Nov 2017
22:09:10 +0000 (UTC)):

Author: wulf
Date: Wed Nov  1 22:09:10 2017
New Revision: 325294
URL: https://svnweb.freebsd.org/changeset/base/325294

Log:
  evdev: Hide "kern.evdev.rcpt_mask" sysctl if kernel is compiled
  w/o EVDEV_SUPPORT as it's value has no meaning in this case.

Now presence of this sysctl can be used for discovery if evdev support
  for hybrid devices is compiled into kernel or not.

If you want to show the presence of a feature in the kernel: we have
the FEATURE() macro for this. It's in sys/sysctl.h and you can use it
like:
    FEATURE(evdev, "evdev protocol support");

That is done in the initial evdev commit. See line 54 of sys/dev/evdev/evdev.c

The presence of this sysctl shows that the support for evdev protocol is compiled into drivers that capable to report events in both traditional an evdev ways.
But, I agree. It is better to add another one FEATURE() line for
"option EVDEV_SUPPORT" than do a conditional exposure of "magic" sysctl.

I will fix that. Thank you.

--
WBR
Vladimir Kondratyev
_______________________________________________
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Reply via email to