On Tue, Dec 05, 2017 at 08:42:11PM -0500, Allan Jude wrote: > On 2017-12-05 20:17, Conrad Meyer wrote: > > Ping. Please revert this change. If you want zstd to behave this > > way, pursue it upstream first. > > > > Thanks, > > Conrad > > > > On Wed, Nov 15, 2017 at 7:38 PM, Conrad Meyer <c...@freebsd.org> wrote: > >> Please revert this change. > >> > >> First, it introduces the POLA-violating behavior that zstdcat deletes > >> its source files. This is not how zcat/bzcat behaves. > >> > >> Second, it introduces a needless behavioral difference between FreeBSD > >> zstd and the rest of the world's zstd. The zstd documentation we ship > >> continues to claim that zstd preserves source files by default, yet > >> this change makes that documentation exactly backwards. While we can > >> change FreeBSD's documentation to accommodate the change, we can't > >> change Google results. > >> > >> Thanks, > >> Conrad > >> > >> On Sat, Apr 15, 2017 at 1:15 PM, Baptiste Daroussin <b...@freebsd.org> > >> wrote: > >>> Author: bapt > >>> Date: Sat Apr 15 20:15:44 2017 > >>> New Revision: 316980 > >>> URL: https://svnweb.freebsd.org/changeset/base/316980 > >>> > >>> Log: > >>> Change some default to make zstd a dropin replacement for gzip,bzip etc > >>> in most cases > >>> > >>> Changes ares: > >>> - quiet by default > >>> - remove the source files one compression completion by default > >>> > >>> Modified: > >>> head/contrib/zstd/programs/fileio.c > >>> head/contrib/zstd/programs/zstdcli.c > >>> > >>> Modified: head/contrib/zstd/programs/fileio.c > >>> ============================================================================== > >>> --- head/contrib/zstd/programs/fileio.c Sat Apr 15 20:06:24 2017 > >>> (r316979) > >>> +++ head/contrib/zstd/programs/fileio.c Sat Apr 15 20:15:44 2017 > >>> (r316980) > >>> @@ -138,7 +138,7 @@ static U32 g_dictIDFlag = 1; > >>> void FIO_setDictIDFlag(unsigned dictIDFlag) { g_dictIDFlag = dictIDFlag; > >>> } > >>> static U32 g_checksumFlag = 1; > >>> void FIO_setChecksumFlag(unsigned checksumFlag) { g_checksumFlag = > >>> checksumFlag; } > >>> -static U32 g_removeSrcFile = 0; > >>> +static U32 g_removeSrcFile = 1; > >>> void FIO_setRemoveSrcFile(unsigned flag) { g_removeSrcFile = (flag>0); } > >>> static U32 g_memLimit = 0; > >>> void FIO_setMemLimit(unsigned memLimit) { g_memLimit = memLimit; } > >>> > >>> Modified: head/contrib/zstd/programs/zstdcli.c > >>> ============================================================================== > >>> --- head/contrib/zstd/programs/zstdcli.c Sat Apr 15 20:06:24 2017 > >>> (r316979) > >>> +++ head/contrib/zstd/programs/zstdcli.c Sat Apr 15 20:15:44 2017 > >>> (r316980) > >>> @@ -61,7 +61,7 @@ > >>> #define MB *(1 <<20) > >>> #define GB *(1U<<30) > >>> > >>> -#define DEFAULT_DISPLAY_LEVEL 2 > >>> +#define DEFAULT_DISPLAY_LEVEL 1 > >>> > >>> static const char* g_defaultDictName = "dictionary"; > >>> static const unsigned g_defaultMaxDictSize = 110 KB; > >>> > > > > Upstream recommends we create an additional hardlink, called 'zz' (like > xz but zstd), to do such compatibility, and keep 'zstd' the same as zstd > on every other distro. >
Actually I would prefer not to do it and simply adapt newsyslog to be more flexible. it is the only consumer of the zstd command. Bapt
signature.asc
Description: PGP signature