Kristof, I just want to note that this is a huge change of behaviour of pf(4) for a user. Over a decade everybody has been used to the difference between "reload" and "resync". Yes, I admit that back in 2008 the difference was awkward and annoying, but todays I'm afraid that change would be more annoying than keeping status quo.
This definitely shouldn't reach stable/11, absolutely. I won't argue about keeping it in head, and thus in 12.0. You are pf maintainer now and you know better. You take the risk of explaining the change to users :) On Mon, Mar 26, 2018 at 09:36:22AM +0000, Kristof Provost wrote: K> Author: kp K> Date: Mon Mar 26 09:36:22 2018 K> New Revision: 331546 K> URL: https://svnweb.freebsd.org/changeset/base/331546 K> K> Log: K> pf: reload and resync do the same thing K> K> The reload and resync commands for the startup script do exactly the same K> thing, so implement one as a call to the other. K> K> MFC after: 3 weeks K> K> Modified: K> head/etc/rc.d/pf K> K> Modified: head/etc/rc.d/pf K> ============================================================================== K> --- head/etc/rc.d/pf Mon Mar 26 09:07:16 2018 (r331545) K> +++ head/etc/rc.d/pf Mon Mar 26 09:36:22 2018 (r331546) K> @@ -53,12 +53,12 @@ pf_check() K> pf_reload() K> { K> echo "Reloading pf rules." K> - $pf_program -n -f "$pf_rules" $pf_flags || return 1 K> - $pf_program -f "$pf_rules" $pf_flags K> + pf_resync K> } K> K> pf_resync() K> { K> + $pf_program -n -f "$pf_rules" $pf_flags || return 1 K> $pf_program -f "$pf_rules" $pf_flags K> } K> K> -- Gleb Smirnoff _______________________________________________ [email protected] mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "[email protected]"
