> On Fri, Apr 06, 2018 at 09:17:09AM -0700, Rodney W. Grimes wrote:
> > [ Charset UTF-8 unsupported, converting... ]
> > > Author: royger
> > > Date: Fri Apr  6 11:20:06 2018
> > > New Revision: 332092
> > > URL: https://svnweb.freebsd.org/changeset/base/332092
> > > 
> > > Log:
> > >   remove GiB/MiB macros from param.h
> > >   
> > >   And instead define them in the files where they are used.
> > 
> > It would of been better to "revert" your prior change and
> > make a seperate new commit.  It is rarely desireable to combine
> > a revert of a change with anything.
> 
> A plain revert of r332072 would have left the tree in a broken state,
> because r332073 depends on those macros. IMO it's better to have a
> buildable tree at all times in order for it to be bisectable.

Well a revert of r332073 could of been combined leaving  the tree
building, and in the state before the attempt to do {MG}iB() macros.

-- 
Rod Grimes                                                 rgri...@freebsd.org
_______________________________________________
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Reply via email to