On Thu, 17 May 2018 13:46:45 +0200
Mateusz Piotrowski <0...@freebsd.org> wrote:

> Hello,
> 
> I think something went wrong here.
> 
> On Thu, 17 May 2018 10:25:49 +0000 (UTC)
> Emmanuel Vadot <m...@freebsd.org> wrote:
> 
> >Author: manu
> >Date: Thu May 17 10:25:49 2018
> >New Revision: 333710
> >URL: https://svnweb.freebsd.org/changeset/base/333710
> >
> >Log:
> >  aw_spi: Add manpage for this driver
> >
> >Added:
> >  head/share/man/man4/aw_spi.4   (contents, props changed)
> >Modified:
> >  head/share/man/man4/Makefile
> >
> >Modified: head/share/man/man4/Makefile
> >==============================================================================
> >--- head/share/man/man4/Makefile     Thu May 17 10:25:01 2018        
> >(r333709)
> >+++ head/share/man/man4/Makefile     Thu May 17 10:25:49 2018        
> >(r333710)
> >@@ -74,6 +74,7 @@ MAN=       aac.4 \
> >     ${_aw_mmc.4} \
> >     ${_aw_rtc.4} \
> >     ${_aw_sid.4} \
> >+    ${_aw_spi.4} \
> >     ${_aw_syscon.4} \
> >     axe.4 \
> >     axge.4 \
> >@@ -773,6 +774,7 @@ _aw_gpio.4=      aw_gpio.4
> > _aw_mmc.4=  aw_mmc.4
> > _aw_rtc.4=  aw_rtc.4
> > _aw_sid.4=  aw_sid.4
> >+_aw_spi.4=  aw_spi.4
> > _aw_syscon.4=       aw_syscon.4
> > .endif
> >
> >
> >Added: head/share/man/man4/aw_spi.4
> >==============================================================================
> >--- /dev/null        00:00:00 1970   (empty, because file is newly added)
> >+++ head/share/man/man4/aw_spi.4     Thu May 17 10:25:49 2018        
> >(r333710)
> >@@ -0,0 +1,116 @@
> >+.\"-
> >+.\" Copyright (c) 2018 Emmanuel Vadot <m...@freebsd.org>
> >+.\" All rights reserved.
> >+.\"
> >+.\" Redistribution and use in source and binary forms, with or without
> >+.\" modification, are permitted provided that the following conditions
> >+.\" are met:
> >+.\" 1. Redistributions of source code must retain the above copyright
> >+.\"    notice, this list of conditions and the following disclaimer.
> >+.\" 2. Redistributions in binary form must reproduce the above copyright
> >+.\"    notice, this list of conditions and the following disclaimer in the
> >+.\"    documentation and/or other materials provided with the distribution.
> >+.\"
> >+.\" THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
> >+.\" ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
> >+.\" IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 
> >PURPOSE
> >+.\" ARE DISCLAIMED.  IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
> >+.\" FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR 
> >CONSEQUENTIAL
> >+.\" DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
> >+.\" OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
> >+.\" HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, 
> >STRICT
> >+.\" LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY 
> >WAY
> >+.\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
> >+.\" SUCH DAMAGE.
> >+.\"
> >+.\" $FreeBSD$
> >+.\"
> >+.Dd May 17, 2018
> >+.Dt AW_SPI 4
> >+.Os
> >+.Sh NAME
> >+.Nm aw_spi
> >+.Nd driver for the SPI controller in Allwinner SoC
> >+.Sh SYNOPSIS
> >+.Cd "device aw_spi"
> >+.Sh DESCRIPTION
> >+The
> >+.Nm
> >+device driver provides support for the Allwinner SPI host controller.
> >+.Sh HARDWARE
> >+The current version of the
> >+.Nm
> >+driver supports the SD/MMC controller with one of the following compatible 
> >strings :
> 
> There's a space before ":". It is a typo, right?

No this is how I wrote but fixed in r333711 since it seems the way to
format this for whatever reason.

> >+.Pp
> >+.Bl -bullet -compact
> >+.It
> >+allwinner,sun8i-h3-spi
> 
> There's no space after the comma. I not sure it this is correct.

 It is, this is a compatible strings for Device Tree Source.

> >+.El
> >+.Sh HISTORY
> >+The
> >+.Nm
> >+device driver first appeared in
> >+.Fx 12.0 .
> >+.Sh AUTHORS
> >+The
> >+.Nm
> >+device driver was written by
> >+.An Emmanuel Vadot Aq Mt m...@freebsd.org .
> >+.\"-
> >+.\" Copyright (c) 2018 Emmanuel Vadot <m...@freebsd.org>
> >+.\" All rights reserved.
> >+.\"
> >...
> 
> It looks like you've got two copies of the same manual page in this
> file.

 Oops.

> Cheers,
> 
> Mateusz Piotrowski

 Thanks,

-- 
Emmanuel Vadot <m...@bidouilliste.com> <m...@freebsd.org>
_______________________________________________
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Reply via email to