Author: jh
Date: Mon May  7 15:30:53 2012
New Revision: 235131
URL: http://svn.freebsd.org/changeset/base/235131

Log:
  MFC r234104:
  
  Apply changes from r233787 to ext2fs:
  
  - Use more natural ip->i_flags instead of vap->va_flags in the final
    flags check.
  - Style improvements.
  
  No functional change intended.
  
  MFC r234139:
  
  Restore the blank line incorrectly removed in r234104.

Modified:
  stable/9/sys/fs/ext2fs/ext2_vnops.c
Directory Properties:
  stable/9/sys/   (props changed)
  stable/9/sys/amd64/include/xen/   (props changed)
  stable/9/sys/boot/   (props changed)
  stable/9/sys/boot/i386/efi/   (props changed)
  stable/9/sys/boot/ia64/efi/   (props changed)
  stable/9/sys/boot/ia64/ski/   (props changed)
  stable/9/sys/boot/powerpc/boot1.chrp/   (props changed)
  stable/9/sys/boot/powerpc/ofw/   (props changed)
  stable/9/sys/cddl/contrib/opensolaris/   (props changed)
  stable/9/sys/conf/   (props changed)
  stable/9/sys/contrib/dev/acpica/   (props changed)
  stable/9/sys/contrib/octeon-sdk/   (props changed)
  stable/9/sys/contrib/pf/   (props changed)
  stable/9/sys/contrib/x86emu/   (props changed)
  stable/9/sys/fs/   (props changed)
  stable/9/sys/fs/ntfs/   (props changed)
  stable/9/sys/i386/conf/XENHVM   (props changed)
  stable/9/sys/kern/subr_witness.c   (props changed)

Modified: stable/9/sys/fs/ext2fs/ext2_vnops.c
==============================================================================
--- stable/9/sys/fs/ext2fs/ext2_vnops.c Mon May  7 15:06:07 2012        
(r235130)
+++ stable/9/sys/fs/ext2fs/ext2_vnops.c Mon May  7 15:30:53 2012        
(r235131)
@@ -426,23 +426,23 @@ ext2_setattr(ap)
                 * if securelevel > 0 and any existing system flags are set.
                 */
                if (!priv_check_cred(cred, PRIV_VFS_SYSFLAGS, 0)) {
-                       if (ip->i_flags
-                           & (SF_NOUNLINK | SF_IMMUTABLE | SF_APPEND)) {
+                       if (ip->i_flags &
+                           (SF_NOUNLINK | SF_IMMUTABLE | SF_APPEND)) {
                                error = securelevel_gt(cred, 0);
                                if (error)
                                        return (error);
                        }
                        ip->i_flags = vap->va_flags;
                } else {
-                       if (ip->i_flags
-                           & (SF_NOUNLINK | SF_IMMUTABLE | SF_APPEND) ||
+                       if (ip->i_flags &
+                           (SF_NOUNLINK | SF_IMMUTABLE | SF_APPEND) ||
                            (vap->va_flags & UF_SETTABLE) != vap->va_flags)
                                return (EPERM);
                        ip->i_flags &= SF_SETTABLE;
                        ip->i_flags |= (vap->va_flags & UF_SETTABLE);
                }
                ip->i_flag |= IN_CHANGE;
-               if (vap->va_flags & (IMMUTABLE | APPEND))
+               if (ip->i_flags & (IMMUTABLE | APPEND))
                        return (0);
        }
        if (ip->i_flags & (IMMUTABLE | APPEND))
_______________________________________________
[email protected] mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-stable-9
To unsubscribe, send any mail to "[email protected]"

Reply via email to