Author: avg
Date: Tue Feb 18 15:29:53 2014
New Revision: 262175
URL: http://svnweb.freebsd.org/changeset/base/262175

Log:
  MFC r258294: Fix ZFS deadlock when sending a snapshot which is mounted
  
  MFC slacker:  smh

Modified:
  stable/9/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dsl_userhold.c
Directory Properties:
  stable/9/sys/   (props changed)
  stable/9/sys/cddl/contrib/opensolaris/   (props changed)

Modified: stable/9/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dsl_userhold.c
==============================================================================
--- stable/9/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dsl_userhold.c      
Tue Feb 18 15:24:59 2014        (r262174)
+++ stable/9/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dsl_userhold.c      
Tue Feb 18 15:29:53 2014        (r262175)
@@ -564,21 +564,23 @@ dsl_dataset_user_release_impl(nvlist_t *
                ddura.ddura_holdfunc = dsl_dataset_hold_obj_string;
                pool = spa_name(tmpdp->dp_spa);
 #ifdef _KERNEL
-               dsl_pool_config_enter(tmpdp, FTAG);
                for (pair = nvlist_next_nvpair(holds, NULL); pair != NULL;
                    pair = nvlist_next_nvpair(holds, pair)) {
                        dsl_dataset_t *ds;
 
+                       dsl_pool_config_enter(tmpdp, FTAG);
                        error = dsl_dataset_hold_obj_string(tmpdp,
                            nvpair_name(pair), FTAG, &ds);
                        if (error == 0) {
                                char name[MAXNAMELEN];
                                dsl_dataset_name(ds, name);
+                               dsl_pool_config_exit(tmpdp, FTAG);
                                dsl_dataset_rele(ds, FTAG);
                                (void) zfs_unmount_snap(name);
+                       } else {
+                               dsl_pool_config_exit(tmpdp, FTAG);
                        }
                }
-               dsl_pool_config_exit(tmpdp, FTAG);
 #endif
        } else {
                /* Non-temporary holds are specified by name. */
_______________________________________________
svn-src-stable-9@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-stable-9
To unsubscribe, send any mail to "svn-src-stable-9-unsubscr...@freebsd.org"

Reply via email to