Hello again Staffan,
Some updates regarding FSRepositoryFactory.setup() from my colleagues. Since 
SVNKit 1.7 calling 
FSRepositoryFactory.setup() and other XXXRepositoryFactory.setup() are not 
necessary.

If you look at SVNKit code, SVNRepositoryFactory class contains static{} block 
that initializes all 
protocols. So this line

SVNRepository fileRepo = SVNRepositoryFactory.create(fileUrl);

will initialize SVNRepositoryFactory class and hence call that block and setup 
everything.
--
Dmitry Pavlenko,
TMate Software,
http://subgit.com/ - git-svn bridge

> FSRepositoryFactory.setup() should be called once, if you want to work with
> file protocol. Even if you work with file:/// protocol
> (SVNURL.fromFile(repositoryFilesystemPath) creates URL, starting with
> file:///) only in one single place.
> 
> You can have a look at FSRepositoryFactory.setup() code, to understand what
> it does. It just registers a regular expression for protocol part of the
> URL ("^file://.*$") to be processed with FSRepositoryFactory class,
> nothing more. If you don't do that, file:/// protocol won't be recognised
> by SVNKit.
> --
> Dmitry Pavlenko,
> TMate Software,
> http://subgit.com/ - git-svn bridge
> 
> > Hi,
> > 
> > Thank you for creating the issue. Like you I wasn't aware of the added
> > command, but in hooks and such it feels really indispensable now.
> > 
> > Implemented the following workaround:
> >         FSRepositoryFactory.setup();
> >         SVNURL fileUrl = SVNURL.fromFile(repositoryFilesystemPath);
> >         SVNRepository fileRepo = SVNRepositoryFactory.create(fileUrl);
> >         SVNDirEntry fileInfo = fileRepo.info(path, revision);
> >         if (fileInfo.getKind() != SVNNodeKind.FILE) {
> >         
> >             throw new IllegalArgumentException("File size operation
> > 
> > attempted on a " + fileInfo.getKind());
> > 
> >         }
> >         return fileInfo.getSize();
> > 
> > What are the effects of running FSRepositoryFactory.setup()? We're not
> > using file:/// URLs anywhere else.
> > 
> > /Staffan
> > 
> > On Mon, Sep 9, 2013 at 2:14 PM, Dmitry Pavlenko 
> > <pavle...@tmatesoft.com>wrote:
> > > Hello Staffan,
> > > 
> > > Looks like that it's not implemented. When Subversion 1.7 was released,
> > > we were so overloaded by
> > > implementation of new working copy format support, that we didn't
> > > notice that there's a new
> > > subcommand in 'svnlook'. But I won't promise that we'll implement it
> > > soon, because now Subversion
> > > 1.8 is released, and we are working hard on SVNKit 1.8.
> > > 
> > > I've created an issue for "filesize" in our tracker
> > > http://issues.tmatesoft.com/issue/SVNKIT-401
> > > so you can track the progress there.
> > > 
> > > --
> > > Dmitry Pavlenko,
> > > TMate Software,
> > > http://subgit.com/ - git-svn bridge
> > > 
> > > > Hi,
> > > > 
> > > > I can't find the equivalent of the command "svnlook filesize" in the
> > > 
> > > SvnKit
> > > 
> > > > API. I was expecting it in SVNLookClient. Tried both 1.7.11 and
> > > > 1.8-SNAPSHOT. Did I miss something or is it not implemented?
> > > > 
> > > > regards
> > > > Staffan

Reply via email to