On Thu, 18 May 2006, Mattias Brändström wrote:
> Madan U Sreenivasan wrote:
> >On Thu, 18 May 2006 00:08:49 +0530, David James <[EMAIL PROTECTED]> wrote:
> >
> >>On 5/16/06, Madan U Sreenivasan <[EMAIL PROTECTED]> wrote:
> >>
> >>>Implement `svnmerge rollback'.
> >>>The `rollback' sub-command can be used to rollback previously integrated
> >>>revisions.
> >>
> >>
> >>Hi Madan,
> >>
> >>This patch looks good except for one small problem in the test suite:
> >> self.launch("touch newfile")
> >>
> >>'touch' isn't available on Windows. So we should do this instead:
> >> open("newfile","w").close()
> >
> >
> >yeah. You are right. Will change this. Thank you for pointing out.
> >
> >Any other comments, Giovanni, Raman, Mattias?
> >
>
> I have taken a quick look at the patch and I think it looks good. It is
> well commented and easy to follow, the new functionality will be useful.
> I think its a good idea to commit.Madan, nice work. After Giovanni's comments are addressed, this is ready for commit. -- Daniel Rall
pgpNA2t90wMTH.pgp
Description: PGP signature
_______________________________________________ Svnmerge mailing list [email protected] http://www.orcaware.com/mailman/listinfo/svnmerge
