On Tue, 2006-09-05 at 15:57 -0700, Daniel L. Rall wrote: > On Fri, 11 Aug 2006, Paul Cook wrote: > > > I'm very new to subversion and svnmerge.py, but I've managed to get a > > working system going to achieve this. My patch (hopefully formatted > > correctly) is below. It may do something stupid, but it seems to be > > working for me at least. > > Hi Paul, thanks for the patch. I've committed it to the Subversion > repository's trunk with some modifications. > > > I'm wondering if it wouldn't be better to support some type of > --svn-args option to handle other options to the 'svn' command-line > binary (e.g. --no-auth-cache, --non-interactive, etc.). This could > also handle --username and --password, though, it might be more > convenient to users to support explicit options for those. > > Thoughts?
Unfortunately I've discovered a problem with the patch I submitted -- it doesn't escape special characters in the username or (especially) in the password. I can't find the correct way to escape shell arguments in Python, so I'll leave it to people more experienced with Python to suggest the solution. Indeed, it might be useful to support other svn arguments too. The advantage of adding support individually is, I suppose, that one can ensure that only "useful" arguments get passed to svn, and means that end users don't have to look up possible command line arguments in two different places. Sorry! Paul _______________________________________________ Svnmerge mailing list [email protected] http://www.orcaware.com/mailman/listinfo/svnmerge
