New commits:
commit aa6b8949ee79da4246c981ff43da8ad24afc6507
Author: Andrew Cagney <[email protected]>
Date: Wed Oct 3 12:37:03 2018 -0400
packets: change type of Message ID to ft_nat (network byte ordered natural)
as expected by IKEv2
The debug-log lines change to:
Message ID: 1 (0x1)
it might be nice for all ft_nat fields to be instead be logged as:
Message ID: 1 (00 00 00 01)
IKEv2: Message ID is a network ordered natural number
By pre-emptively converting the Message ID network <-> host order in
the packet parser, byte-swap code litering IKEv2 can be eliminated.
The field .msgid_received field _should_ be redundant (as you can tell by
this comment, things instead break because wierd msgid games are being
played).
IKEv1: Message ID is either 0 or a random value
Since internal Message IDs are all re-ordered code testing for
equality or zero continues to work (and logging the value as an
integer no longer needs to convert).
The got-ya is in IKEv1's auth code where the host byte-ordered
Messsage ID needs to be converted to network order before being
fed into the hmac.
_______________________________________________
Swan-commit mailing list
[email protected]
https://lists.libreswan.org/mailman/listinfo/swan-commit
