I tried to merge smoother-nss into master and the result had several
unexpected compile-time warnings.
It turns out that master has those, even without my merging.
I don't think we should be checking in things that result in such
diagnostics.
/home/hugh/libreswan/libreswan/programs/pluto/ikev2_parent.c: In function
‘ikev2_parent_outI1_common’:
/home/hugh/libreswan/libreswan/programs/pluto/ikev2_parent.c:475:3: warning:
implicit declaration of function ‘ikev2_out_nat_v2n’
[-Wimplicit-function-declaration]
ikev2_out_nat_v2n(np, &md->rbody, md);
^
/home/hugh/libreswan/libreswan/programs/pluto/ikev2_parent.c:475:3: warning:
nested extern declaration of ‘ikev2_out_nat_v2n’ [-Wnested-externs]
/home/hugh/libreswan/libreswan/programs/pluto/ikev2_parent.c: In function
‘ikev2parent_inI1outR1’:
/home/hugh/libreswan/libreswan/programs/pluto/ikev2_parent.c:762:4: warning:
implicit declaration of function ‘ikev2_natd_lookup’
[-Wimplicit-function-declaration]
ikev2_natd_lookup(md, FALSE);
^
/home/hugh/libreswan/libreswan/programs/pluto/ikev2_parent.c:762:4: warning:
nested extern declaration of ‘ikev2_natd_lookup’ [-Wnested-externs]
/home/hugh/libreswan/libreswan/programs/pluto/ikev2_parent.c: In function
‘ikev2parent_inI2outR2’:
/home/hugh/libreswan/libreswan/programs/pluto/ikev2_parent.c:1760:2: warning:
implicit declaration of function ‘nat_traversal_change_port_lookup’
[-Wimplicit-function-declaration]
nat_traversal_change_port_lookup(md, st);
^
/home/hugh/libreswan/libreswan/programs/pluto/nat_traversal.c: In function
‘nat_traversal_show_result’:
/home/hugh/libreswan/libreswan/programs/pluto/nat_traversal.c:678:56: warning:
unused parameter ‘sport’ [-Wunused-parameter]
void nat_traversal_show_result(u_int32_t nt, u_int16_t sport)
^
/home/hugh/libreswan/libreswan/programs/pluto/nat_traversal.c: In function
‘nat_traversal_change_port_lookup’:
/home/hugh/libreswan/libreswan/programs/pluto/nat_traversal.c:1017:4: warning:
format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 3 has
type ‘int’ [-Wformat=]
pluto_natt_float_port);
^
/home/hugh/libreswan/libreswan/programs/pluto/nat_traversal.c: At top level:
/home/hugh/libreswan/libreswan/programs/pluto/nat_traversal.c:1167:6: warning:
no previous declaration for ‘ikev2_natd_lookup’ [-Wmissing-declarations]
void ikev2_natd_lookup(struct msg_digest *md, bool rc)
^
/home/hugh/libreswan/libreswan/programs/pluto/nat_traversal.c: In function
‘ikev2_natd_lookup’:
/home/hugh/libreswan/libreswan/programs/pluto/nat_traversal.c:1184:11: warning:
assignment discards ‘const’ qualifier from pointer target type [enabled by
default]
rcookie = zero_cookie;
^_______________________________________________
Swan-dev mailing list
[email protected]
https://lists.libreswan.org/mailman/listinfo/swan-dev
