I committed a fix. May be there is a better one. MAXIMUM_RETRANSMISSIONS_INITIAL * EVENT_RETRANSMIT_DELAY_0 the default timeout is 200 seconds (20 * 10sec).
-antony On Thu, Jun 05, 2014 at 07:02:57PM -0400, Paul Wouters wrote: > On Fri, 6 Jun 2014, Antony Antony wrote: > > >Here is a proposed patch, add timeout_event EVENT_SO_DISCARD to > >STATE_PARENT_R1 with timeout value of: > > > >MAXIMUM_RETRANSMISSIONS_INITIAL + EVENT_RETRANSMIT_DELAY_0 > >The default is 30 seconds. > > I am confused. MAXIMUM_RETRANSMISSIONS_INITIAL is used to set > maximum_retransmissions_initial which is a counter, not a time unit. > Also, MAXIMUM_RETRANSMISSIONS_INITIAL is a compile time default which > is used to set maximum_retransmissions_initial, so I believe you would > then want to use maximum_retransmissions_initial. > > But still I am not sure as other implementations might use other values. > > Our EVENT_RETRANSMIT_DELAY_0 is 10 seconds, so 30 seconds would cover 2 > or 3 resends of the initiator. I think it is fine, especially as we > still need to bring our own resend timers down to sub-second levels. > > So pehraps just set it to event_retransmit_delay_0 ? > > Paul > _______________________________________________ Swan-dev mailing list [email protected] https://lists.libreswan.org/mailman/listinfo/swan-dev
