Kill it Sent from my iPhone
> On Jul 4, 2017, at 17:59, D. Hugh Redelmeier <[email protected]> wrote: > > I'm sorry that my question wasn't clearer. > > Here's the definition: > > const struct id *resolve_myid(const struct id *id) > { > return id; > } > > It clearly does NOTHING. It does not allow roadwarriors to declare their > ID since it does nothing. > > If we intend to build on it later, that's fine. But as-is, I don't see > why we have it (or its source file). > > Are we intending to make it do something useful? > > If so, we should document this with comments on the function. > > If not, shall we delete it? > > | From: Paul Wouters <[email protected]> > | > | > What's the point of resolve_myid()? It seems like it doesn't do anything > | > (formally: it is the identity function). Did it formerly have a > | > purpose? Does it have a future purpose? > | > | It was used for roadwarriors to declare their ID to allow forward DNS > | lookups for IPSECKEY (aka "Initiator only OE") > | > | It probably has less of a use now, as our aim has changed to keep > | roadwarriors anonymous using AUTH_NULL. > | > | > If it is pointless, let's get rid of it. And the sourcefile lswid.c that > | > contains only the definition of resolve_myid(). > | > | I'm okay with removing it. Someone who would really need it could edit > | the OE conns and add their own custom leftid= > _______________________________________________ > Swan-dev mailing list > [email protected] > https://lists.libreswan.org/mailman/listinfo/swan-dev _______________________________________________ Swan-dev mailing list [email protected] https://lists.libreswan.org/mailman/listinfo/swan-dev
