> -----Original Message----- > From: Tuomo Soini [mailto:[email protected]] > Subject: Re: [Swan-dev] [libreswan RFC 1/3] kernel_netlink: Detect netlink > SA failures > > On Tue, 11 Jul 2017 18:09:05 +0300 > [email protected] wrote: > > > From: Ilan Tayari <[email protected]> > > > > If the kernel responds with an error to NEWSA or DELSA, > > current code disregards this. > > Detect failures and return a proper value to the caller. > > > > This is required for nic-offload-fallback to work. > > > > Signed-off-by: Ilan Tayari <[email protected]> > > I suggest checking coding style of these patches. You can use > checkpatch.pl from kernel sources to check. > > checkpatch.pl --no-tree 0001-your-changes.patch > > There are several errors in this patch set. >
I see several real ones, and lots of false positives. Will fix in v2. Thanks Tuomo! _______________________________________________ Swan-dev mailing list [email protected] https://lists.libreswan.org/mailman/listinfo/swan-dev
