On Sun, 6 Aug 2017, Ilan Tayari wrote:

libreswan code do not treat pointers as boolean; atleast try to avoid it.
the above line would something like :
c->interface != NULL || c->interface->ip_dev != NULL ||
c->interface->ip_dev->id_rname != NULL

There are a few more cases where pointer is used as boolean, it will good
to
clean up. I have pointed this out in the previous reviews.

Sorry about that. I forgot.
Context-switching between project conventions has its cost :/

Did you fix this in master too?

AFAIK, those were all fixed in current git master.

Paul
_______________________________________________
Swan-dev mailing list
Swan-dev@lists.libreswan.org
https://lists.libreswan.org/mailman/listinfo/swan-dev

Reply via email to