On Nov 5, 2017, at 15:55, Aviv Heller <[email protected]> wrote: >>> I've made some minor changes. Could you review these before I commit >> them? Also please next time send a patch as attachment, so there isn't >> whitespace translations that I need to do surgery on :) > > Hi Paul, > > Thanks for taking the time to review my patch. > > A couple of cosmetic points, based on the updated version of your patch: > 1) At netlink_esp_hw_offload struct definition and the 'if (i >= cmd->len)' > on line 908, the indentation was done with spaces instead of tabs (sorry for > the trouble, I will use a .patch file next time:).
We use tabs :) > 2) At 926 'bool ret = false' instead of FALSE. We use the capital letter versions of those too, so that was also a conscious decision. I mostly meant the flipped if/then to confirm you were okay with that :) Paul _______________________________________________ Swan-dev mailing list [email protected] https://lists.libreswan.org/mailman/listinfo/swan-dev
