(I screwed up and accidentally replied off list, I've expanded my initial reply)
On Tue, 21 Aug 2018 at 14:10, D. Hugh Redelmeier <[email protected]> wrote: > > I was reading this function (but not looking at the contexts from which it > may be called) > > What is the meaning of proposal->integ != NULL? > Is it effectively a synonym for proposal->integ != &ike_alg_integ_none? Why? As in what would suggest that? At one point an algorithm with the value NULL was special, but those days are long gone. Here's the relevant code: if (proposal->encrypt != NULL && encrypt_desc_is_aead(proposal->encrypt) && proposal->integ != NULL && proposal->integ != &ike_alg_integ_none) { /* * For instance, esp=aes_gcm-sha1" is invalid. Just like for ->encrypt!=NULL (should that have raised a flag?) it simply means that there isn't any algorithm at all. > Why is it OK for the non-aead case? > _______________________________________________ > Swan-dev mailing list > [email protected] > https://lists.libreswan.org/mailman/listinfo/swan-dev _______________________________________________ Swan-dev mailing list [email protected] https://lists.libreswan.org/mailman/listinfo/swan-dev
