Er, don't we already have functions to boilerplate at least SK payloads?
typedef struct v2sk_payload {
struct ike_sa *ike;
pb_stream pbs;
/* pointers into payload buffer (not .payload) */
uint8_t *iv;
uint8_t *cleartext; /* where cleartext starts */
uint8_t *integrity;
} v2sk_payload_t;
v2sk_payload_t open_v2sk_payload(pb_stream *container,
struct ike_sa *st);
bool close_v2sk_payload(v2sk_payload_t *sk);
stf_status encrypt_v2sk_payload(v2sk_payload_t *sk);
On Fri, 28 Sep 2018 at 11:18, D. Hugh Redelmeier
<[email protected]> wrote:
>
> New commits:
> commit 9a4b391b006fcfd7a90dea888d31019cc545cf3f
> Author: D. Hugh Redelmeier <[email protected]>
> Date: Fri Sep 28 11:17:24 2018 -0400
>
> pluto: IKEv2: create functions for boilerplate for starting and ending
> SK/SKF payloads
>
> This hairy code now appears only once instead of being repeated,
> perhaps imperfectly, n times.
>
> Possible future project: absorbing fragmentation into this. Currently
> some packets are not considered for fragmentation which would seem to
> be a mistake.
>
> Sprinkled const.
>
> _______________________________________________
> Swan-commit mailing list
> [email protected]
> https://lists.libreswan.org/mailman/listinfo/swan-commit
_______________________________________________
Swan-dev mailing list
[email protected]
https://lists.libreswan.org/mailman/listinfo/swan-dev
