On Mon, 29 Jul 2019 at 08:38, Andrew Cagney <[email protected]> wrote:
> These make variables should only be expanded when web pages are enabled? > Per the comment: > > # shortcuts to use when web is enabled, set up to evaluate once as > # they can be a little expensive. These make variable can only be > # used inside of WEB_ENABLED blocks. > In fact it was working. Here's what happens in my tree using the commit just before the below: $ v=$(gmake showversion) $ echo $v 3.28-506-g423d0e04bd-HEAD $ v=$(make showversion LSW_WEBDIR=..) + cd . + git show --no-patch --format=%H HEAD + testing/web/gime-git-description.sh . $ echo $v 3.28-506-g423d0e04bd-HEAD $ so I'm stumped as to why the below behaviour occurred. Andrew At one point they were very expensive, unconditionally expanded, and > repeatedly making everything slow. Hence their verbosity - so we can see > if the bug has crept back in > (from memory, most of the expense was in computing 'dirty' which is why > the web page code doesn't do that) > > Andrew > > ---------- Forwarded message --------- > From: Antony Antony <[email protected]> > Date: Mon, 29 Jul 2019 at 08:01 > Subject: [Swan-commit] Changes to ref refs/heads/master > To: <[email protected]> > > > New commits: > commit 367867e7124949f029c5bf0b3b0f527384770bad > Author: Antony Antony <[email protected]> > Date: Sun Jul 21 11:08:10 2019 +0000 > > testing: remove set -x from web-targets.mk > > after: > make showversion > 3.28-504-g5113b92b34-master > > before: > make showversion > + cd . > + git show --no-patch --format=%H HEAD > + testing/web/gime-git-description.sh . > 3.28-504-g5113b92b34-dirty-master > > _______________________________________________ > Swan-commit mailing list > [email protected] > https://lists.libreswan.org/mailman/listinfo/swan-commit >
_______________________________________________ Swan-dev mailing list [email protected] https://lists.libreswan.org/mailman/listinfo/swan-dev
