ah, yes, thanks for explaining that
On Sat, 17 Aug 2019 at 10:42, D. Hugh Redelmeier <[email protected]> wrote: > > | commit b473d2b9be0a244672aa2934e3feaac55ad23b82 > | Author: Andrew Cagney <[email protected]> > | Date: Sat Aug 17 08:08:56 2019 -0400 > | > | redirect: in emit_redirect_notification_decoded_dest() delete '-' in > column 1 negating a bool > | > | Looks like a merge botch. Worryingly, fixing this doesn't seem to > | affect test results - it would have caused the initiator code path > | to always fail? > | > | See 4e3d1805639c05e3fd00c4d175979916111476b5 > > Good catch! Thanks. > > Interestingly, in C, applying "-" to a bool does not change the value > if it is used as a bool. > > a: false true > -a: 0 -1 > (bool) -a: false true > > So: no testing could find this bug since it causes no difference in > behaviour. > _______________________________________________ > Swan-dev mailing list > [email protected] > https://lists.libreswan.org/mailman/listinfo/swan-dev _______________________________________________ Swan-dev mailing list [email protected] https://lists.libreswan.org/mailman/listinfo/swan-dev
