On Thu, 12 Dec 2019 at 14:50, Paul Wouters <[email protected]> wrote: > > This is not correct! > > Aliased connections with auto=start must get revived. Similar for > narrowing=yes connections which become instances.
The revival code uses c->name as the connection identifier, not c->connalias. So if a connection brought up using an alias goes down then c->name should re-find it. However, for instances, things seem more interesting. Is there a test I should look at? My assumption was that by the time revival occurred the connection instance should be long gone? (As an aside, conn_by_name() re-orders the connection list - so if both the conn and its instance were in the list then luck would determine which was found). > Paul > > Sent from my iPhone > > Begin forwarded message: > > From: Andrew Cagney <[email protected]> > Date: December 12, 2019 at 14:38:09 EST > To: [email protected] > Subject: [Swan-commit] Changes to ref refs/heads/master > Reply-To: [email protected] > > New commits: > commit 1aef3b5d0c58b301afb49999d05aab92aade5d93 > Author: Andrew Cagney <[email protected]> > Date: Thu Dec 12 09:34:14 2019 -0500 > > revival: cleanup initiate_connection(), don't revive instances or aliases > > Add separate initiate_connections_by_name(). Drop debug and impair > parameters. Suppress futile whack_log() call - in revive_cons() there > is no whack. > > _______________________________________________ > Swan-commit mailing list > [email protected] > https://lists.libreswan.org/mailman/listinfo/swan-commit > > _______________________________________________ > Swan-dev mailing list > [email protected] > https://lists.libreswan.org/mailman/listinfo/swan-dev _______________________________________________ Swan-dev mailing list [email protected] https://lists.libreswan.org/mailman/listinfo/swan-dev
