On Tue, 28 Jan 2020 at 11:10, Antony Antony <[email protected]> wrote: > > On Tue, Jan 28, 2020 at 10:45:54AM -0500, Andrew Cagney wrote: > > On Tue, 28 Jan 2020 at 10:22, Antony Antony <[email protected]> wrote: > > > > > > On Tue, Jan 28, 2020 at 09:19:52AM -0500, Andrew Cagney wrote: > > > > On Tue, 28 Jan 2020 at 06:31, Antony Antony <[email protected]> wrote: > > > > > > > > > > the markers should be used in nicinit for simple tests where we use > > > > > eastinit.sh, nicinit.sh and final.sh > > > > > > > > why > > > > Thanks for the useful answer. > you are welcome. > > I am curious what your thoughts now? > Is it a good idea to add " : ==== end ====" to nicinit.sh when final.sh is > not necessary. Or just Antony's preference? The test author can decide?
As an instrument I find it blunt. It removes everything so useful stuff run during the post-mortem, such as checking for a core file, is lost. My preference would be to get away from final.sh (instead have generic tear down code that, like swan-prep, runs silently unless there's a real error). > I have a feeling that I have been arguing this for over 8+ years! > > -antony _______________________________________________ Swan-dev mailing list [email protected] https://lists.libreswan.org/mailman/listinfo/swan-dev
