Begin forwarded message:
> From: Andrew Cagney <[email protected]> > Date: March 9, 2020 at 11:32:17 EDT > To: [email protected] > Subject: [Swan-commit] Changes to ref refs/heads/master > Reply-To: [email protected] > > New commits: > commit 7a7224b0e2381c416decb1d08bc191cd9fd783f1 > Author: Andrew Cagney <[email protected]> > Date: Mon Mar 9 11:27:01 2020 -0400 > > ikev2: rename enum notify_payload_hash_algorithms to enum > ikev2_hash_algorithm This is confusing. We have an IANA registry for ikev2 hash (integ) algorithms and this is not it. See: https://www.iana.org/assignments/ikev2-parameters/ikev2-parameters.xhtml#ikev2-parameters-7 Versus: https://www.iana.org/assignments/ikev2-parameters/ikev2-parameters.xhtml#hash-algorithms The first is a transform type, the second is a notify value. Better name would be ikev2_rfc7427_hash_algo ? I fear ikev2_hash_algorithm is prone to be misused as a transform value. Paul
_______________________________________________ Swan-dev mailing list [email protected] https://lists.libreswan.org/mailman/listinfo/swan-dev
