On 4 February 2015 at 16:50, Chris Miles <[email protected]> wrote: > When using swfdump on swf's with a large constant pool (more than 1024 > strings) swfdump crashes. > > The below patch allows up to 8192 strings in the pool and stops the crash if > the limit is exceeded. > > Chris > > $ git branch -v > * master b6e946b fix crashes reported by Debian Cylab Mayhem Team > > $ git diff > diff --git a/lib/modules/swfaction.c b/lib/modules/swfaction.c > index bd248ec..52d966c 100644 > --- a/lib/modules/swfaction.c > +++ b/lib/modules/swfaction.c > @@ -23,7 +23,8 @@ > > #include "../rfxswf.h" > > -#define MAX_LOOKUP 1024 // make cross references in dumps > +//#define MAX_LOOKUP 1024 // make cross references in dumps > +#define MAX_LOOKUP 8192 // make cross references in dumps > > struct Action > { > @@ -466,7 +467,7 @@ void swf_DumpActions(ActionTAG*atag, char*prefix) > U32 offset = value[0]+(value[1]<<8); > printf(" Lookup16:%d", offset); > #ifdef MAX_LOOKUP > - if (lookup[offset]) > + if (offset < MAX_LOOKUP && lookup[offset]) > printf(" (\"%s\")",lookup[offset]); > #endif > } else {
Hi Chris, Thanks for submitting the above patch. Further SWFTools development has temporarily ceased, however consideration is begin given to a maintaining the project in a more accessible way, including a bug tracker, and Git repository based upon the last 'official' repo maintained. When ( if ) the above occurs, you may wish to apply your patch directly. Regards, Chris. --------------- SWFTools-common is a self-managed list. To subscribe/unsubscribe, or amend an existing subscription, please kindly point your favourite web browser at:<http://lists.nongnu.org/mailman/listinfo/swftools-common>
