Hi Alexander, Small incremental changes is usually a good approach.
As for adding tests first, we can do that but we just need to make sure they don’t fail the build. What approach would you have in mind for that? - Tony > On Apr 22, 2016, at 1:37 AM, Alexander Alemayhu via swift-corelibs-dev > <swift-corelibs-dev@swift.org> wrote: > > Hei Everyone, > > I have been reading the documentation the last couple of days and have been > thinking that it would make more sense to try to tackle this via several > incremental changes vs a large pull request some time in the future. What do > you > think? > > If that is preferred, I would purpose as a first step to introduce [tests][1] > for NSFileHandle. Adding tests in general sounds like a good idea, but I am > not > sure how one should test NSFileHandle. Would it be a good starting point to > add > tests for the methods used by [plutil][2]? > > Thanks. > > [1]: > https://github.com/apple/swift-corelibs-foundation/blob/master/TestFoundation/main.swift > > <https://github.com/apple/swift-corelibs-foundation/blob/master/TestFoundation/main.swift> > > [2]: > https://github.com/apple/swift-corelibs-foundation/blob/master/Tools/plutil/main.swift > > <https://github.com/apple/swift-corelibs-foundation/blob/master/Tools/plutil/main.swift> > > -- > Mit freundlichen Grüßen > > Alexander Alemayhu > _______________________________________________ > swift-corelibs-dev mailing list > swift-corelibs-dev@swift.org > https://lists.swift.org/mailman/listinfo/swift-corelibs-dev
_______________________________________________ swift-corelibs-dev mailing list swift-corelibs-dev@swift.org https://lists.swift.org/mailman/listinfo/swift-corelibs-dev
