> On Jun 21, 2017, at 6:30 AM, Alex Blewitt via swift-corelibs-dev 
> <swift-corelibs-dev@swift.org> wrote:
> 
> We had a test failure on swift-corelibs-foundation recently on master, which 
> was related to this pull request being merged by me:
> 
> https://github.com/apple/swift-corelibs-foundation/pull/1043 
> <https://github.com/apple/swift-corelibs-foundation/pull/1043>
> 
> The automated tests passed, but after being committed to master, they then 
> failed. I subsequently rolled them back with this pull request:
> 
> https://github.com/apple/swift-corelibs-foundation/pull/1056 
> <https://github.com/apple/swift-corelibs-foundation/pull/1056>
> 
> A few interim builds have failed; if you see messages like failing to compare 
> metric and imperial measurements, that could have been caused by this. 
> Rebasing and redoing such test failures should fix the issues.
> 
> It's a bit concerning that the test case failed after merge but passed in the 
> pull request test. Is this expected?

I’m not 100% sure that our test cases are being run against a clean build, 
which has been the root of some confusion like this in the past.

- Tony

> 
> Alex
> Test Case 'TestNSLengthFormatter.test_stringFromMetersMetric' started at 
> 2017-06-21 10:16:31.688
> TestFoundation/TestNSLengthFormatter.swift:71: error: 
> TestNSLengthFormatter.test_stringFromMetersMetric : XCTAssertEqual failed: 
> ("-6.214 mi") is not equal to ("-10 km") - 
> TestFoundation/TestNSLengthFormatter.swift:72: error: 
> TestNSLengthFormatter.test_stringFromMetersMetric : XCTAssertEqual failed: 
> ("-0.001 mi") is not equal to ("-0.001 km") - 
> TestFoundation/TestNSLengthFormatter.swift:73: error: 
> TestNSLengthFormatter.test_stringFromMetersMetric : XCTAssertEqual failed: 
> ("0 in") is not equal to ("0.01 mm") - 
> _______________________________________________
> swift-corelibs-dev mailing list
> swift-corelibs-dev@swift.org
> https://lists.swift.org/mailman/listinfo/swift-corelibs-dev

_______________________________________________
swift-corelibs-dev mailing list
swift-corelibs-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-corelibs-dev

Reply via email to